-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 2428 python embedding with MET_PYTHON_EXE defined #2462
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
51aed28
#2428 Initial release
550f473
#2428 Added read_tmp_point_nc.py and write_tmp_point_nc.py
7c9f16d
#2428 Added met_point_obs_nc.py
8017e01
#2428 Added python_point2grid_pb2nc_TMP_user_python
5ee645e
#2428 Changed log message
339803a
#2428 Moved GP, tmp_nc_base_name, and tmp_nc_file_var_name to python3…
7634474
#2428 Moved nc_tools to met_point_obs_nc.py
9912f42
#2428 Moved nc_point_obs to met_point_obs_nc.py
d7dabde
#2428 Added tmp_nc_point_obs
4b6e032
#2428 Do not check if MET_PYTHON_EXE is the same as the MET_PYTHON_BI…
72cd3fb
#2428 Do not add MET_BASE/python path
447ac0b
#2428 Set use_var_id at put_data()
4eba029
#2428 Set use_var_id from the global attribute
61bf6d9
Fixed typo.
DanielAdriaansen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
######################################################################## | ||
# | ||
# Reads temporary point obs. file into memory. | ||
# | ||
# usage: /path/to/python read_tmp_point_nc.py tmp_output_filename | ||
# | ||
######################################################################## | ||
|
||
import os | ||
import sys | ||
|
||
# add share/met/python directory to system path to find met_point_obs | ||
sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), | ||
os.pardir, 'python'))) | ||
from met_point_obs import met_point_obs | ||
from met_point_obs_nc import nc_point_obs | ||
|
||
netcdf_filename = sys.argv[1] | ||
|
||
# read NetCDF file | ||
print('{p} reading{f}'.format(p=met_point_obs.get_prompt(), f=netcdf_filename)) | ||
point_obs_data = nc_point_obs() | ||
point_obs_data.read_data(netcdf_filename) | ||
|
||
met_point_data = point_obs_data.get_point_data() | ||
met_point_data['met_point_data'] = point_obs_data |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
######################################################################## | ||
# | ||
# Adapted from a script provided by George McCabe | ||
# Adapted by Howard Soh | ||
# | ||
# usage: /path/to/python write_tmp_point_nc.py \ | ||
# tmp_output_filename <user_python_script>.py <args> | ||
# | ||
######################################################################## | ||
|
||
import os | ||
import sys | ||
import importlib.util | ||
|
||
# add share/met/python directory to system path to find met_point_obs | ||
sys.path.append(os.path.abspath(os.path.join(os.path.dirname(__file__), | ||
os.pardir, 'python'))) | ||
|
||
from met_point_obs import met_point_obs | ||
from met_point_obs_nc import nc_point_obs | ||
|
||
PROMPT = met_point_obs.get_prompt() | ||
print("{p} Python Script:\t".format(p=PROMPT) + repr(sys.argv[0])) | ||
print("{p} User Command:\t".format(p=PROMPT) + repr(' '.join(sys.argv[2:]))) | ||
print("{p} Temporary File:\t".format(p=PROMPT) + repr(sys.argv[1])) | ||
|
||
tmp_filename = sys.argv[1] | ||
pyembed_module_name = sys.argv[2] | ||
sys.argv = sys.argv[2:] | ||
|
||
# append user script dir to system path | ||
pyembed_dir, pyembed_file = os.path.split(pyembed_module_name) | ||
if pyembed_dir: | ||
sys.path.insert(0, pyembed_dir) | ||
|
||
if not pyembed_module_name.endswith('.py'): | ||
pyembed_module_name += '.py' | ||
|
||
user_base = os.path.basename(pyembed_module_name).replace('.py','') | ||
|
||
spec = importlib.util.spec_from_file_location(user_base, pyembed_module_name) | ||
met_in = importlib.util.module_from_spec(spec) | ||
spec.loader.exec_module(met_in) | ||
|
||
if hasattr(met_in, 'point_obs_data'): | ||
met_in.point_obs_data.save_ncfile(tmp_filename) | ||
else: | ||
if hasattr(met_in.met_point_data, 'point_obs_data'): | ||
met_in.met_point_data['point_obs_data'].save_ncfile(tmp_filename) | ||
else: | ||
tmp_point_obs = nc_point_obs() | ||
tmp_point_obs.put_data(met_in.met_point_data) | ||
tmp_point_obs.save_ncfile(tmp_filename) | ||
|
||
#print('{p} writing {f}'.format(p=PROMPT, f=tmp_filename)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of this logic looks to be the same as other scripts in the data/wrappers directory. We should consider pulling out duplicate code into a function. This isn't required for this PR and could be done during a bigger refactor of the Python Embedding logic.