Bugfix #2170 main_v10.1 agg_ecnt #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
15 tasks
… when it should not.
jprestop
reviewed
Jun 9, 2022
Co-authored-by: jprestop <[email protected]>
jprestop
reviewed
Jun 9, 2022
jprestop
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
I inspected the code change, confirmed that the unit tests flagged a difference in the output, only in the ME and RMSE output columns of the Stat-Analysis agg ecnt job, and reviewed the doc updates about percentile thresholds. I made a couple of suggested corrections for "gt" to "ge" and "!-" to "!=", and I think the "!=" still needs to be made before merging. I approve this request.
Co-authored-by: jprestop <[email protected]>
|
Thanks Julie. No idea why I made those silly typos. Thanks for catching them! Guess I was trying to multi task too much. |
JohnHalleyGotway
added a commit
that referenced
this pull request
Jun 10, 2022
Co-authored-by: George McCabe <[email protected]> Co-authored-by: johnhg <[email protected]> Co-authored-by: Julie Prestopnik <[email protected]> Co-authored-by: Howard Soh <[email protected]> Co-authored-by: hsoh-u <[email protected]> Co-authored-by: jprestop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Manually tested to confirm that the aggregated ECNT ME and RMSE written by Stat-Analysis are no longer a constant value of 0. Note that this same issue affects the ME_OERR and RMSE_OERR columns, but those were already set to NA.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
It corrects the output of an existing Stat-Analysis test.
Please complete this pull request review by [Fri 6/10/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes