Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1293 regrid #1297

Merged
merged 6 commits into from
Apr 13, 2020
Merged

Feature 1293 regrid #1297

merged 6 commits into from
Apr 13, 2020

Conversation

JohnHalleyGotway
Copy link
Collaborator

Please see details in #1293

@JohnHalleyGotway
Just fix typo in a comment.
0f69f79
@JohnHalleyGotway
Per #1293, update the regrid dictionary to support the convert(), cen…
2aad8e5 
…sor_thresh, and censor_val options. Update the logic in met_regrid.cc to apply these after doing the regridding. Add corresponding command line options to regrid_data_plane for -convert_x and -censor. Add a new call to regrid_data_plane in unit_regrid.xml to exercise them.
@JohnHalleyGotway
Per #1293, define DataPlane::convert() member function and call it bo…
0382ad6 
…th from data_class.cc and vx_regrid.cc.
@JohnHalleyGotway
Per #1293, change regrid_data_plane command line option from -convert…
5be83b3 
…_x to -convert based on feedback from Lindsay and Julie.
@JohnHalleyGotway
Per #1293, adding DataPlane::convert() adds a new dependency for -lvx…
c2c3d21 
…_util on -lvx_config. Had to add -lvx_config to the Makefile for plot_mode_field.
@JohnHalleyGotway
Per #1293, correctly list the expected output file name in the unit_r…
82b8a1e 
…egrid.xml.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 9.1 milestone Apr 10, 2020
@JohnHalleyGotway JohnHalleyGotway requested a review from hsoh-u April 10, 2020 21:58
@JohnHalleyGotway JohnHalleyGotway changed the base branch from master_v9.0 to develop April 10, 2020 21:59
hsoh-u
hsoh-u approved these changes Apr 11, 2020
View reviewed changes
Copy link
Collaborator

@hsoh-u hsoh-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clean and well documented.

@JohnHalleyGotway JohnHalleyGotway merged commit cf21c94 into develop Apr 13, 2020
@JohnHalleyGotway JohnHalleyGotway deleted the feature_1293_regrid branch April 13, 2020 18:37
@JohnHalleyGotway JohnHalleyGotway changed the title Pull request to merge feature_1293_regrid into develop feature 1293 regrid into develop Apr 17, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title feature 1293 regrid into develop feature 1293 regrid Apr 21, 2020
@JohnHalleyGotway JohnHalleyGotway changed the title feature 1293 regrid Feature 1293 regrid Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsoh-u hsoh-u hsoh-u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
MET 9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnHalleyGotway @hsoh-u