-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the vector level matching logic when reading NetCDF output generated by other MET tools #3087
Closed
11 of 24 tasks
Closed
11 of 24 tasks
Labels
MET: Wind Verification
priority: medium
Medium Priority
requestor: UK Met Office
United Kingdom Met Office
type: enhancement
Improve something that it is currently doing
Milestone
Comments
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 18, 2025
…ore the requested level string to allow for discriminating between multiple U/V vertical level matches.
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 18, 2025
…temp_file.cc that caused an unexpected copmilation error with GCC 9.4.0 on Ubuntu as described in the dtcenter/METplus#2897 discussion.
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 18, 2025
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 18, 2025
…e creating vector pairs at multiple levels from NetCDF input files.
17 tasks
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 19, 2025
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 19, 2025
…string to just a string itself. This is based on SonarQube code smells, but the implementation is much simpler and easier to maintain.
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 19, 2025
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 19, 2025
…num class and the use of explicit since those had huge and wide-ranging impacts. Touching that many files is not worth it to reduce SonarQube code smells.
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 20, 2025
…t_point2grid.xml by switching from requesting the 'Z2' level to using '*', like all the other simliar point2grid tests. Note that I DID actually test to confirm that 'Z2' and '*' produce the same result. So specifying Z2 does NOT actually filter the obs data as you'd expect it would. With this change, the diff of the output from the test should go away for PR #3088.
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 20, 2025
… line from the Ensemble-Stat chapter of the MET User's Guide referencing the 'ens' dictionary which was removed at the same time Gen-Ens-Prod was created.
JohnHalleyGotway
added a commit
that referenced
this issue
Feb 20, 2025
* Per #3087, update logic in VarInfoNcMet::set_magic(...) to actuall store the requested level string to allow for discriminating between multiple U/V vertical level matches. * Unrelated to #3087, delete unneeded 'int errno;' local variable from temp_file.cc that caused an unexpected copmilation error with GCC 9.4.0 on Ubuntu as described in the dtcenter/METplus#2897 discussion. * Per #3087, tweak logic to handle '*' and fix resolve regression test differences. * Per #3087, add regrid_data_plane and grid_stat unit test to demostrate creating vector pairs at multiple levels from NetCDF input files. * Per #3087, forgot to add the Grid-Stat config file needed for the new unit test. * Per #3075, refine name and logic the new tests. * Per #3087, update ConcatString class to simplify from a pointer to a string to just a string itself. This is based on SonarQube code smells, but the implementation is much simpler and easier to maintain. * Per #3087, drive down a few more SonarQube code smells. * Per #3087, back out the ConcatString changes to switch from enum to enum class and the use of explicit since those had huge and wide-ranging impacts. Touching that many files is not worth it to reduce SonarQube code smells. * Per #3087, modify the existing point2grid_pb2nc_big_input test in unit_point2grid.xml by switching from requesting the 'Z2' level to using '*', like all the other simliar point2grid tests. Note that I DID actually test to confirm that 'Z2' and '*' produce the same result. So specifying Z2 does NOT actually filter the obs data as you'd expect it would. With this change, the diff of the output from the test should go away for PR #3088. * Unrelated to #3087, but pointed out by @j-opatz, removing an outdated line from the Ensemble-Stat chapter of the MET User's Guide referencing the 'ens' dictionary which was removed at the same time Gen-Ens-Prod was created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MET: Wind Verification
priority: medium
Medium Priority
requestor: UK Met Office
United Kingdom Met Office
type: enhancement
Improve something that it is currently doing
Describe the Enhancement
This issue arose via the dtcenter/METplus#2898 discussion. The task is to enhance the
vx_data2d_nc_met
library to better support computing VL1L2/VAL1L2/VCNT vector statistics at multiple levels when reading data from MET NetCDF files.Demonstrate the issue to be addressed by running the following commands:
Where
GridStatConfig_UV
includes:And generates the following warning messages:
In addition:
grid_stat
orpoint_stat
.temp_file.cc
(int errno;
) since it is NOT needed and may cause a compilation error as described in the Error when installing METplus--12.0.2 METplus#2897 discussion.Time Estimate
< 1 day
Sub-Issues
Consider breaking the enhancement down into sub-issues.
None needed.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Spend up to 2 h of NCAR base (2702701)
Define the Metadata
Assignee
Labels
Milestone and Projects
Define Related Issue(s)
Consider the impact to the other METplus components.
No impacts expected.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: MET-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: