Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Point-Stat to compute SEEPS for point observations and write new SEEPS and SEEPS_MPR STAT line types. #1942

Closed
6 of 21 tasks
RachelNorth opened this issue Oct 14, 2021 · 6 comments · Fixed by #2257
Closed
6 of 21 tasks
Assignees
Labels
MET: Grid-to-Point Verification MET: Probability Verification priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Milestone

Comments

@RachelNorth
Copy link

RachelNorth commented Oct 14, 2021

Describe the New Feature

The Stable Equitable Error in Probability Space (SEEPS) score is described in Rodwell et al. (2010) and was devised for evaluating quantitative precipitation forecasts against SYNOP gauge data at (but not limited to) station locations. It uses a climatology to account for local variations in rainfall which enables aggregation over otherwise heterogenous locations.

This issue will detail the work required to implement this capability within MET and to act as an umbrella issue to log progress as it is likely that implementing this will require division into further sub-issues.

Changes will be required to Point-Stat in order to compute the score.
Support for a point-based climatology will be required. MET #1941 has been opened for the work required for this capability.

This issue will supersede the SEEPS portion of MET #563.

This still needs more definition on how to implement.

The tasks for this work include:

  • Enhance Point-Stat to compute SEEPS.
  • Enhance Stat-Analysis to compute SEEPS from the matched pair (MPR) input lines.

There is no way to mathematically aggregate SEEPS over multiple runs. Instead we just compute the mean of the SEEPS over multiple runs.

We do still need to define the columns that should be included in a new SEEPS line type.

Acceptance Testing

List input data types and sources.
Input data expected to be either ASCII text or NetCDF files.
Original IDL code can be provided to compare scores. Example C code is provided in the google drive link at #563 (comment)

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2799991

Define the Metadata

Assignee

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@RachelNorth RachelNorth added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle type: new feature Make it do something new labels Oct 14, 2021
@RachelNorth RachelNorth changed the title Implement calculation of SEEPS Implement calculation of SEEPS in Point-Stat Oct 14, 2021
@JohnHalleyGotway JohnHalleyGotway changed the title Implement calculation of SEEPS in Point-Stat Implement calculation of SEEPS for verification against point observations. Oct 14, 2021
@JohnHalleyGotway JohnHalleyGotway added MET: Grid-to-Point Verification priority: high requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Oct 14, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.1.0 milestone Oct 14, 2021
@TaraJensen TaraJensen removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Nov 4, 2021
@TaraJensen TaraJensen modified the milestones: MET 10.1.0, MET 11.0.0 Jan 6, 2022
@JohnHalleyGotway JohnHalleyGotway removed this from the Consider for Next Release milestone Apr 7, 2022
hsoh-u pushed a commit that referenced this issue Sep 13, 2022
hsoh-u pushed a commit that referenced this issue Sep 13, 2022
hsoh-u pushed a commit that referenced this issue Sep 13, 2022
hsoh-u pushed a commit that referenced this issue Sep 13, 2022
hsoh-u pushed a commit that referenced this issue Sep 13, 2022
@hsoh-u hsoh-u moved this from To Do to Pull Request Review in MET-11.0.0-beta3 (9/21/22) Sep 14, 2022
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 14, 2022 that will close this issue
15 tasks
JohnHalleyGotway pushed a commit that referenced this issue Sep 15, 2022
JohnHalleyGotway pushed a commit that referenced this issue Sep 15, 2022
…and also do not set the obs_valid_beg and obs_valid_end timestamps.
JohnHalleyGotway added a commit that referenced this issue Sep 15, 2022
…sts. Update the lists of expected output files to include the newly generated seeps outputs.
@JohnHalleyGotway
Copy link
Collaborator

@hsoh-u, do the seeps point climo values in PPT24_seepsweights.nc ONLY apply to 24-hour accumulations of precip? I'm guessing that that's the case, but want to confirm.

If so we need to add that logic in Point-Stat. Right now, those climo values are being applied to 3-hourly accumulations in the Point-Stat unit tests. We'll need to update Point-Stat to only compute SEEPS for 24-hour accumulations of precip.

Of course, it'd make sense to handle climos for other accumulation intervals and/or other variable altogether. In the next round of development, we may want to rethink how we configure things. Perhaps we have the user specify the path to the point climo data file directly in the obs.field array entry (e.g. point_climo = "MET_BASE/climo/seeps/PPT24_seepsweights.nc";)? If its specified, we use that to compute seeps. If empty, we don't compute seeps. That'd make things more configurable for the user and also make the logic in the code much easier... just use whatever point climo data the user has provided.

JohnHalleyGotway added a commit that referenced this issue Sep 16, 2022
…tings configurable. It is produced for 3 of the 4 unit tests that use that config file. Disable it's output for the 4th. The question remains as to whether seeps should be computed for ALL precip variables, or only for 24-hour accumulations. If it's the latter, none of these existing tests will work.
@hsoh-u
Copy link
Collaborator

hsoh-u commented Sep 16, 2022

It's not checking if 24 hour precipitations. Rachel's recommendation was focusing 24 hours. SEEPS can be calculated for any accumulation length for which the user has an appropriate climatology.

hsoh-u pushed a commit that referenced this issue Sep 16, 2022
hsoh-u pushed a commit that referenced this issue Sep 16, 2022
@JohnHalleyGotway JohnHalleyGotway linked a pull request Sep 16, 2022 that will close this issue
18 tasks
@JohnHalleyGotway JohnHalleyGotway removed a link to a pull request Sep 16, 2022
18 tasks
JohnHalleyGotway added a commit that referenced this issue Sep 16, 2022
…r APCP. Modify the PB2NC config file to write out TP24 point observations.
Repository owner moved this from Pull Request Review to Done in MET-11.0.0-beta3 (9/21/22) Sep 16, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Implement calculation of SEEPS for verification against point observations. Enhance Point-Stat to compute SEEPS for point observations and write new SEEPS and SEEPS_MPR STAT line types. Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Grid-to-Point Verification MET: Probability Verification priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center requestor: UK Met Office United Kingdom Met Office required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: new feature Make it do something new
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants