From b812535176381c0a5b16465de004fa230a39bb85 Mon Sep 17 00:00:00 2001
From: John Halley Gotway <johnhg@ucar.edu>
Date: Thu, 15 Sep 2022 22:36:38 -0600
Subject: [PATCH] Per #1942, update the PointStatConfig_APCP file to make the
 seeps settings configurable. It is produced for 3 of the 4 unit tests that
 use that config file. Disable it's output for the 4th. The question remains
 as to whether seeps should be computed for ALL precip variables, or only for
 24-hour accumulations. If it's the latter, none of these existing tests will
 work.

---
 .../test_unit/config/PointStatConfig_APCP     | 13 ++++++-----
 internal/test_unit/xml/unit_point_stat.xml    | 22 +++++--------------
 2 files changed, 13 insertions(+), 22 deletions(-)

diff --git a/internal/test_unit/config/PointStatConfig_APCP b/internal/test_unit/config/PointStatConfig_APCP
index d5d40c3c1a..d777ae8583 100644
--- a/internal/test_unit/config/PointStatConfig_APCP
+++ b/internal/test_unit/config/PointStatConfig_APCP
@@ -39,6 +39,9 @@ wind_thresh = [ NA ];
 wind_logic  = UNION;
 eclv_points = 0.05;
 
+cat_thresh   = [ >0.254, >0.635, >1.270, >2.540 ];
+message_type = "ADPSFC";
+
 fcst = {
    sid_inc = [];
    sid_exc = [];
@@ -47,10 +50,8 @@ fcst = {
    
    field = [
       {
-         name         = "${FCST_FIELD_NAME}";
-         level        = "${FCST_FIELD_LEVEL}";
-         cat_thresh   = [ >0.254, >0.635, >1.270, >2.540 ];
-         message_type = "ADPSFC";
+         name  = "${FCST_FIELD_NAME}";
+         level = "${FCST_FIELD_LEVEL}";         
       }
    ];
 
@@ -126,8 +127,8 @@ output_flag = {
    rps    = NONE;
    eclv   = BOTH;
    mpr    = NONE;
-   seeps  = BOTH;
-   seeps_mpr = BOTH;
+   seeps  = ${SEEPS_FLAG};
+   seeps_mpr = ${SEEPS_FLAG};
 }
 
 ////////////////////////////////////////////////////////////////////////////////
diff --git a/internal/test_unit/xml/unit_point_stat.xml b/internal/test_unit/xml/unit_point_stat.xml
index 188fca3770..5216dd8461 100644
--- a/internal/test_unit/xml/unit_point_stat.xml
+++ b/internal/test_unit/xml/unit_point_stat.xml
@@ -166,6 +166,7 @@
       <pair><name>FCST_FIELD_NAME</name>  <value>APCP</value></pair>
       <pair><name>FCST_FIELD_LEVEL</name> <value>A3</value></pair>
       <pair><name>OBS_DICT</name>         <value>fcst</value></pair>
+      <pair><name>SEEPS_FLAG</name>       <value>BOTH</value></pair>
       <pair><name>OUTPUT_PREFIX</name>    <value>GRIB1_NAM_TRMM</value></pair>
     </env>
     <param> \
@@ -194,6 +195,7 @@
       <pair><name>FCST_FIELD_NAME</name>  <value>APCP</value></pair>
       <pair><name>FCST_FIELD_LEVEL</name> <value>A3</value></pair>
       <pair><name>OBS_DICT</name>         <value>fcst</value></pair>
+      <pair><name>SEEPS_FLAG</name>       <value>BOTH</value></pair>
       <pair><name>OUTPUT_PREFIX</name>    <value>GRIB2_SREF_TRMM</value></pair>
     </env>
     <param> \
@@ -221,13 +223,8 @@
       <pair><name>END_DS</name>           <value>1800</value></pair>
       <pair><name>FCST_FIELD_NAME</name>  <value>APCP_24</value></pair>
       <pair><name>FCST_FIELD_LEVEL</name> <value>(*,*)</value></pair>
-      <pair><name>OBS_DICT</name>         <value>{ field = [
-                                                     { name         = "APCP";
-                                                       level        = "A24";
-                                                       cat_thresh   = [ >0.254, >0.635, >1.270, >2.540 ];
-                                                       message_type = "ADPSFC";
-                                                     }
-                                                   ]; }</value></pair>
+      <pair><name>OBS_DICT</name>         <value>{ field = [ { name  = "APCP"; level = "A24"; } ]; }</value></pair>
+      <pair><name>SEEPS_FLAG</name>       <value>NONE</value></pair>
       <pair><name>OUTPUT_PREFIX</name>    <value>NCMET_NAM_HMTGAGE</value></pair>
     </env>
     <param> \
@@ -243,8 +240,6 @@
       <stat>&OUTPUT_DIR;/point_stat/point_stat_NCMET_NAM_HMTGAGE_360000L_20120410_120000V_cts.txt</stat>
       <stat>&OUTPUT_DIR;/point_stat/point_stat_NCMET_NAM_HMTGAGE_360000L_20120410_120000V_cnt.txt</stat>
       <stat>&OUTPUT_DIR;/point_stat/point_stat_NCMET_NAM_HMTGAGE_360000L_20120410_120000V_sl1l2.txt</stat>
-      <stat>&OUTPUT_DIR;/point_stat/point_stat_NCMET_NAM_HMTGAGE_360000L_20120410_120000V_seeps.txt</stat>
-      <stat>&OUTPUT_DIR;/point_stat/point_stat_NCMET_NAM_HMTGAGE_360000L_20120410_120000V_seeps_mpr.txt</stat>
     </output>
   </test>
 
@@ -255,13 +250,8 @@
       <pair><name>END_DS</name>           <value>150000000</value></pair>
       <pair><name>FCST_FIELD_NAME</name>  <value>RAINNC</value></pair>
       <pair><name>FCST_FIELD_LEVEL</name> <value>(0,*,*)</value></pair>
-      <pair><name>OBS_DICT</name>         <value>{ field = [
-                                                     { name         = "APCP";
-                                                       level        = "A3";
-                                                       cat_thresh   = [ >0.254, >0.635, >1.270, >2.540 ];
-                                                       message_type = "ADPSFC";
-                                                     }
-                                                   ]; }</value></pair>
+      <pair><name>OBS_DICT</name>         <value>{ field = [ { name = "APCP"; level = "A3"; } ]; }</value></pair>
+      <pair><name>SEEPS_FLAG</name>       <value>BOTH</value></pair>
       <pair><name>OUTPUT_PREFIX</name>    <value>NCPINT_TRMM</value></pair>
     </env>
     <param> \