From 303ab449768f29c2a1eb519eb538e09af6e80a95 Mon Sep 17 00:00:00 2001 From: George McCabe <23407799+georgemccabe@users.noreply.github.com> Date: Wed, 19 Jan 2022 16:27:02 -0700 Subject: [PATCH] removed echo commands to group log output to allow script/job to fail if the docker commands fail. The scripts are now called in separate steps that generate their own log files so these groups are no longer needed anyway. --- .github/jobs/build_docker_image.sh | 2 -- .github/jobs/push_docker_image.sh | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/jobs/build_docker_image.sh b/.github/jobs/build_docker_image.sh index 2c48c63cec..f479e07c53 100755 --- a/.github/jobs/build_docker_image.sh +++ b/.github/jobs/build_docker_image.sh @@ -21,8 +21,6 @@ DOCKERHUB_TAG=dtcenter/met:${branch_name} DOCKERFILE_DIR=${GITHUB_WORKSPACE}/scripts/docker -echo "::group::Docker Build Command" time_command docker build -t ${DOCKERHUB_TAG} \ --build-arg SOURCE_BRANCH=$branch_name \ $DOCKERFILE_DIR -echo "::endgroup::" diff --git a/.github/jobs/push_docker_image.sh b/.github/jobs/push_docker_image.sh index 7138c45710..73ec0ae489 100755 --- a/.github/jobs/push_docker_image.sh +++ b/.github/jobs/push_docker_image.sh @@ -27,6 +27,4 @@ fi echo "$DOCKER_PASSWORD" | docker login --username "$DOCKER_USERNAME" --password-stdin -echo "::group::Docker Push Command" time_command docker push ${DOCKERHUB_TAG} -echo "::endgroup::"