Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Seed padding issue #544

Closed
magnified103 opened this issue Mar 7, 2025 · 0 comments · Fixed by #546
Closed

[BUG] - Seed padding issue #544

magnified103 opened this issue Mar 7, 2025 · 0 comments · Fixed by #546
Assignees
Labels
bug Something isn't working

Comments

@magnified103
Copy link
Contributor

Description

Currently, the initial seed for key generation is padded with ASCII '0'. As a result, seeds like node1 and node10 produce the same key and peerID.

A simple fix is to pad the seed with ASCII null (\x00). A better solution is to use a dedicated padding algorithm such as PKCS#7

Version

ALL

Reproduction URL

No response

Reproduction steps

N/A

Screenshots

DESCRIPTION

Logs

Browsers

No response

OS

No response

@magnified103 magnified103 added the bug Something isn't working label Mar 7, 2025
@magnified103 magnified103 self-assigned this Mar 7, 2025
@sfroment sfroment linked a pull request Mar 9, 2025 that will close this issue
2 tasks
@sfroment sfroment closed this as completed Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants