Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink auto-dial logic for topic discovery in the network #265

Closed
d-roak opened this issue Nov 19, 2024 · 3 comments · Fixed by #363
Closed

Rethink auto-dial logic for topic discovery in the network #265

d-roak opened this issue Nov 19, 2024 · 3 comments · Fixed by #363
Assignees
Labels
enhancement Improvement on something

Comments

@d-roak
Copy link
Contributor

d-roak commented Nov 19, 2024

Currently, we are auto-dialing on discovery, with the DHT we'd still be dialing anything that's stored there. We need further considerations on the topic
ChainSafe/js-libp2p-gossipsub#510 (comment)

@d-roak d-roak added the enhancement Improvement on something label Nov 19, 2024
@sfroment
Copy link
Member

sfroment commented Jan 10, 2025

The last comment around Relay in golang is really something we might want to implement one day.
Otherwise I think what we want is a place where peer can "search" for there DRP a bit like the rendezvous protocol but to find DRP and who are in this DRP
https://github.com/libp2p/specs/blob/master/rendezvous/README.md

@sfroment
Copy link
Member

as a note in the connection manager settings there is this settings:

/**
   * Sort the known addresses of a peer before trying to dial, By default public
   * addresses will be dialled before private (e.g. loopback or LAN) addresses.
   */
  addressSorter?: AddressSorter

Maybe it could help us remove the sorting we have in identify

@sfroment
Copy link
Member

linked to #363

@d-roak d-roak linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants