Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[세션, 북마크] 세션 목록에서 북마크 여부가 노출된다 #236

Closed
wisemuji opened this issue Aug 23, 2023 · 3 comments · Fixed by #242
Closed

[세션, 북마크] 세션 목록에서 북마크 여부가 노출된다 #236

wisemuji opened this issue Aug 23, 2023 · 3 comments · Fixed by #242
Assignees
@kez-lab
Labels
2023 난이도 : 하

Comments

@wisemuji
Copy link
Member

wisemuji commented Aug 23, 2023 •
edited
Loading

Kind (Required)

  • Improvement

Overview (Required)

  • 디자인
  • 세션 목록에서 북마크된 세션은 북마크아이콘과 북마크태그가 추가되어 노출한다.
  • 북마크되지 않은 세션은 별도의 UI 변경이 없다.
  • 세션 상세에서의 데이터 변경사항을 어떻게 감지할지 고민이 필요하다.
image

Links
@wisemuji wisemuji changed the title [세션, 북마크] 세션 목록에서 북마크를 변경할 수 있다 [세션, 북마크] 세션 목록에서 북마크 여부가 노출된다 Aug 23, 2023
@kez-lab
Copy link
Contributor

kez-lab commented Aug 25, 2023

🙋‍♂️

@wisemuji
Copy link
Member Author

@KwakEuiJin 감사합니다!
도움이 필요하시다면 편하게 알려주세요.

@wisemuji
Copy link
Member Author

@KwakEuiJin 관련 작업중인 PR도 첨부합니다.

#234

@kez-lab kez-lab mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kez-lab kez-lab

Labels
2023 난이도 : 하
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Feature/session_bookmark]: 북마크 UI 추가 작업 kez-lab/DroidKnightsApp
3 participants
@taehwandev @wisemuji @kez-lab