Skip to content

Commit

Permalink
fix(header): Set a height for .bar .title
Browse files Browse the repository at this point in the history
WP8 does not obey the ellipsis or nowrap and allows text to go below
the header. Setting a height forces the title from getting too tall.
  • Loading branch information
Adam Bradley committed May 13, 2014
1 parent aa15f8e commit 0c960b5
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions scss/_bar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@
margin: 0 10px;

min-width: 30px;
height: $bar-height - 1;

text-align: center;

Expand Down Expand Up @@ -135,8 +136,8 @@
padding: 0 $button-bar-button-padding;
min-width: initial;
min-height: $button-bar-button-height - 1;
font-size: $button-bar-button-font-size;
font-weight: 400;
font-size: $button-bar-button-font-size;
line-height: $button-bar-button-height;

&.button-icon:before,
Expand All @@ -162,10 +163,10 @@
}
}
&.button-clear {
font-size: $bar-title-font-size;
font-weight: 300;
padding-right: 2px;
padding-left: 2px;
font-weight: 300;
font-size: $bar-title-font-size;

.icon:before,
&.icon:before,
Expand All @@ -192,7 +193,7 @@
.button + .button-bar {
margin-left: 5px;
}

// Android 4.4 messes with the display property
.buttons,
.buttons.left-buttons,
Expand Down

0 comments on commit 0c960b5

Please sign in to comment.