From 8d04bdbf40d3c1a22090d1ba120cf5d85c99dc68 Mon Sep 17 00:00:00 2001
From: zhangw <zhang9748@foxmail.com>
Date: Wed, 19 Mar 2025 11:55:14 +0800
Subject: [PATCH 1/2] feat: support disable defined name
---
packages/sheets-ui/src/views/defined-name/DefinedName.tsx | 1 +
packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/packages/sheets-ui/src/views/defined-name/DefinedName.tsx b/packages/sheets-ui/src/views/defined-name/DefinedName.tsx
index 8320942c49c..6dcfa6645b8 100644
--- a/packages/sheets-ui/src/views/defined-name/DefinedName.tsx
+++ b/packages/sheets-ui/src/views/defined-name/DefinedName.tsx
@@ -67,6 +67,7 @@ export function DefinedName({ disable }: { disable: boolean }) {
<DefinedNameOverlay />
</div>
)}
+ disabled={disable}
>
<a
className={clsx(`
diff --git a/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx b/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx
index f88c99c704e..941ff4deebf 100644
--- a/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx
+++ b/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx
@@ -42,10 +42,11 @@ enum ArrowDirection {
interface IProps {
className?: string;
+ disableDefinedName?: boolean;
}
export function FormulaBar(props: IProps) {
- const { className } = props;
+ const { className, disableDefinedName } = props;
const [iconStyle, setIconStyle] = useState<string>(styles.formulaGrey);
const [arrowDirection, setArrowDirection] = useState<ArrowDirection>(ArrowDirection.Down);
@@ -264,7 +265,7 @@ export function FormulaBar(props: IProps) {
}}
>
<div className={styles.nameRanges}>
- <DefinedName disable={editDisable} />
+ <DefinedName disable={disableDefinedName??editDisable} />
</div>
<div className={styles.formulaBar}>
From 47f454ff2b1526c8cf9d3fc6db40ed95fb1c886d Mon Sep 17 00:00:00 2001
From: zhangw <zhang9748@foxmail.com>
Date: Wed, 19 Mar 2025 12:07:34 +0800
Subject: [PATCH 2/2] fix: lint
---
packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx b/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx
index 941ff4deebf..5002523a1cc 100644
--- a/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx
+++ b/packages/sheets-ui/src/views/formula-bar/FormulaBar.tsx
@@ -265,7 +265,7 @@ export function FormulaBar(props: IProps) {
}}
>
<div className={styles.nameRanges}>
- <DefinedName disable={disableDefinedName??editDisable} />
+ <DefinedName disable={disableDefinedName ?? editDisable} />
</div>
<div className={styles.formulaBar}>