From df177a6033fac6a23e6a0e13261f21473a4b8aab Mon Sep 17 00:00:00 2001 From: "T.J. Schuck" Date: Wed, 12 Apr 2017 16:39:29 -0400 Subject: [PATCH] Add dev/test dependency and fix broken test `TestNetHttpPersistent#test_pipeline` was getting skipped by default, since `net-http-pipeline` wasn't installed as a test dependency. However, when installed, the skipped test was failing with `NoMethodError: undefined method `start' for #`. This adds `net-http-pipeline` as a dev dependency so the test isn't skipped in CI and fixes the test so it passes. --- Rakefile | 5 +++-- test/test_net_http_persistent.rb | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/Rakefile b/Rakefile index 499d465..7b00401 100644 --- a/Rakefile +++ b/Rakefile @@ -20,8 +20,9 @@ Hoe.spec 'net-http-persistent' do rdoc_locations << 'docs.seattlerb.org:/data/www/docs.seattlerb.org/net-http-persistent/' - dependency 'connection_pool', '~> 2.2' - dependency 'minitest', '~> 5.2', :development + dependency 'connection_pool', '~> 2.2' + dependency 'minitest', '~> 5.2', :development + dependency 'net-http-pipeline', '~> 1.0', :development end # vim: syntax=Ruby diff --git a/test/test_net_http_persistent.rb b/test/test_net_http_persistent.rb index fa64570..c7f4dd1 100644 --- a/test/test_net_http_persistent.rb +++ b/test/test_net_http_persistent.rb @@ -751,7 +751,7 @@ def test_pipeline skip 'net-http-pipeline not installed' unless defined?(Net::HTTP::Pipeline) cached = basic_connection - cached.start + cached.http.start requests = [ Net::HTTP::Get.new((@uri + '1').request_uri),