-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming changes in reagent 0.8.0 #128
Comments
Got it working in branch reagent-0.8 using ClojureScript 1.9.908 and |
Any update on this getting into master? |
Reagent 0.8 is still alpha, so might be a bit early. |
@drapanjanas dropping this over here hoping that it might be helpful. If you haven't changed the automatic J's require inference code, this would break once you start using js libraries inside the namespaces. This is because the inference was based on the I don't have a good solution for that yet, but mentioning it is better than letting it fail ;) |
@carocad thanks, I am aware of this. I also do not have any good solution to solve it at the moment. |
Recent changes in the cljs compiler allow including js libraries as namespaces. This may end up cleaning up the code for cljsrn users quite a bit.
Reagent will probably use this functionality: reagent-project/reagent#306
This may also require some changes to re-natal, however. Off the top of my head, empty cljsjs namespaces will not be required anymore. It's not clear to me how the changes in both Reagent and the Cljs compiler will interact with the RN packager. It may be necessary to set the
target
compiler option to:node-js
.It would be a good idea to try moving re-natal to the upcoming reagent 0.8.0 SNAPSHOT version.
The text was updated successfully, but these errors were encountered: