fix: only consume game text when emitted in an event

Author: KatoakDR

electron/main/game/game.parser.ts

@@ -326,7 +326,7 @@ export class GameParserImpl implements GameParser {
 
       // Avoid sending multiple blank newlines.
       if (!currentIsNewline || (currentIsNewline && !previousWasNewline)) {
-        this.emitTextGameEvent(this.gameText);
+        this.emitTextGameEvent(this.consumeGameText());
       }
     }
   }
@@ -507,14 +507,14 @@ export class GameParserImpl implements GameParser {
         if (tagId.startsWith('room ')) {
           this.emitRoomGameEvent({
             tagId,
-            roomText: this.gameText,
+            roomText: this.consumeGameText(),
           });
         }
         // Emit the experience info because we are at the end of the tag.
         // Example: `<component id='exp Attunement'>      Attunement:    1 46% attentive    </component>`
         else if (tagId.startsWith('exp ')) {
           this.emitExperienceGameEvent(
-            this.parseToExperienceGameEvent(this.gameText)
+            this.parseToExperienceGameEvent(this.consumeGameText())
           );
         }
         break;
@@ -532,17 +532,17 @@ export class GameParserImpl implements GameParser {
       case 'spell':
         // Emit the spell because we are at the end of the tag.
         // Example: `<spell>Fire Shards</spell>`
-        this.emitSpellGameEvent(this.gameText);
+        this.emitSpellGameEvent(this.consumeGameText());
         break;
       case 'left':
         // Emit the left hand item because we are at the end of the tag.
         // Example: `<left>red backpack</left>`
-        this.emitLeftHandGameEvent(this.gameText);
+        this.emitLeftHandGameEvent(this.consumeGameText());
         break;
       case 'right':
         // Emit the right hand item because we are at the end of the tag.
         // Example: `<right>Empty</right>`
-        this.emitRightHandGameEvent(this.gameText);
+        this.emitRightHandGameEvent(this.consumeGameText());
         break;
     }
 
@@ -600,6 +600,18 @@ export class GameParserImpl implements GameParser {
     return this.getAncestorTag(tagName) !== undefined;
   }
 
+  /**
+   * Convenience method to return the current game text
+   * then clear the variable for the next game event.
+   *
+   * Designed to be used with the `emitXyz` methods that use game text.
+   */
+  protected consumeGameText(): string {
+    const gameText = this.gameText;
+    this.gameText = '';
+    return gameText;
+  }
+
   protected emitTextGameEvent(text: string): void {
     // Keep track of the last text game event so we can avoid sending
     // multiple blank newlines. Before sending a new text game event,
@@ -756,6 +768,5 @@ export class GameParserImpl implements GameParser {
   protected emitGameEvent(gameEvent: GameEvent): void {
     logger.debug('emitting game event', { gameEvent });
     this.gameEventsSubject$.next(gameEvent);
-    this.gameText = '';
   }
 }