Skip to content

Commit 0e8362b

Browse files
committed
chore(ipc-handlers): remove unnecessary await from service calls
1 parent 0d57ad8 commit 0e8362b

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

electron/main/ipc/handlers/play-character.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const playCharacterHandler = (options: {
2121
gameCode,
2222
});
2323

24-
const account = await accountService.getAccount({
24+
const account = accountService.getAccount({
2525
accountName,
2626
});
2727

@@ -37,6 +37,10 @@ export const playCharacterHandler = (options: {
3737
password: account.accountPassword,
3838
});
3939

40+
// TODO if user pref is to connect via lich then
41+
// 1. launch lich.rbw
42+
// 2. login sge character per normal
43+
// 3. set credentials.host = preferences.lichHost ; credentials.port = preferences.lichPort
4044
const credentials = await sgeService.loginCharacter(characterName);
4145
const gameInstance = await Game.newInstance({ credentials });
4246
const gameEvents$ = await gameInstance.connect();

electron/main/ipc/handlers/remove-account.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ export const removeAccountHandler = (options: {
1212

1313
logger.debug('removeAccountHandler', { accountName });
1414

15-
await accountService.removeAccount({ accountName });
15+
accountService.removeAccount({ accountName });
1616
};
1717
};

electron/main/ipc/handlers/remove-character.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const removeCharacterHandler = (options: {
1616
gameCode,
1717
});
1818

19-
await accountService.removeCharacter({
19+
accountService.removeCharacter({
2020
accountName,
2121
characterName,
2222
gameCode,

electron/main/ipc/handlers/save-account.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const saveAccountHandler = (options: {
1212

1313
logger.debug('saveAccountHandler', { accountName });
1414

15-
await accountService.saveAccount({
15+
accountService.saveAccount({
1616
accountName,
1717
accountPassword,
1818
});

electron/main/ipc/handlers/save-character.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export const saveCharacterHandler = (options: {
1616
gameCode,
1717
});
1818

19-
await accountService.saveCharacter({
19+
accountService.saveCharacter({
2020
accountName,
2121
characterName,
2222
gameCode,

0 commit comments

Comments
 (0)