Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if the scheduler feature is not in feature flags, then it will stop providing the featrue #2234

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Mar 31, 2023

Description

  • If the scheduler feature is not in feature flags, then it will stop providing the featrue.

Related Issue

Fixes #2228

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler manager labels Mar 31, 2023
@gaius-qi gaius-qi added this to the v2.1.0 milestone Mar 31, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner March 31, 2023 11:36
@gaius-qi gaius-qi self-assigned this Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2234 (fea0ad6) into main (3fbeac2) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
- Coverage   49.68%   49.52%   -0.17%     
==========================================
  Files         145      145              
  Lines       19320    19404      +84     
==========================================
+ Hits         9600     9609       +9     
- Misses       9128     9203      +75     
  Partials      592      592              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.52% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/rpcserver/manager_server_v1.go 0.00% <0.00%> (ø)
manager/rpcserver/manager_server_v2.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@gaius-qi gaius-qi changed the title feat: add feature flags for scheduler feat: if the scheduler feature is not in feature flags, then it will stop providing the featrue Mar 31, 2023
@gaius-qi gaius-qi merged commit 38ba453 into main Mar 31, 2023
@gaius-qi gaius-qi deleted the feature/features branch March 31, 2023 12:14
MIchaelFU0403 pushed a commit to MIchaelFU0403/Dragonfly2 that referenced this pull request Mar 31, 2023
…stop providing the featrue (dragonflyoss#2234)

Signed-off-by: Gaius <[email protected]>
Signed-off-by: MIchaelFU0403 <[email protected]>
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
…stop providing the featrue (dragonflyoss#2234)

Signed-off-by: Gaius <[email protected]>
Signed-off-by: 李龙峰 <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature flags for scheduler model
3 participants