-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: if the scheduler feature is not in feature flags, then it will stop providing the featrue #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <[email protected]>
…e/features Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/features
branch
from
March 31, 2023 11:38
a709de8
to
8822486
Compare
Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/features
branch
from
March 31, 2023 11:41
8822486
to
fea0ad6
Compare
Codecov Report
@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
- Coverage 49.68% 49.52% -0.17%
==========================================
Files 145 145
Lines 19320 19404 +84
==========================================
+ Hits 9600 9609 +9
- Misses 9128 9203 +75
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
changed the title
feat: add feature flags for scheduler
feat: if the scheduler feature is not in feature flags, then it will stop providing the featrue
Mar 31, 2023
yxxhero
approved these changes
Mar 31, 2023
hyy0322
approved these changes
Mar 31, 2023
MIchaelFU0403
pushed a commit
to MIchaelFU0403/Dragonfly2
that referenced
this pull request
Mar 31, 2023
…stop providing the featrue (dragonflyoss#2234) Signed-off-by: Gaius <[email protected]> Signed-off-by: MIchaelFU0403 <[email protected]>
lilongfeng0902
pushed a commit
to lilongfeng0902/Dragonfly2
that referenced
this pull request
May 15, 2023
…stop providing the featrue (dragonflyoss#2234) Signed-off-by: Gaius <[email protected]> Signed-off-by: 李龙峰 <[email protected]>
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
…stop providing the featrue (#2234) Signed-off-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #2228
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist