Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trace https proxy request #996

Merged
merged 2 commits into from
Jan 17, 2022
Merged

feat: trace https proxy request #996

merged 2 commits into from
Jan 17, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jan 15, 2022

Signed-off-by: Jim Ma [email protected]

Description

  1. Trace https proxy request
  2. Add Trace ID into log if tracing is enabled.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner January 15, 2022 09:40
Signed-off-by: Jim Ma <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #996 (e82bd4e) into main (3afbbd0) will decrease coverage by 0.02%.
The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   46.05%   46.02%   -0.03%     
==========================================
  Files         130      130              
  Lines        9074     9092      +18     
==========================================
+ Hits         4179     4185       +6     
- Misses       4433     4440       +7     
- Partials      462      467       +5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.02% <60.86%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/proxy/proxy.go 9.77% <0.00%> (-0.04%) ⬇️
client/daemon/peer/peertask_conductor.go 57.09% <52.94%> (-0.13%) ⬇️
client/daemon/peer/peertask_manager.go 41.89% <100.00%> (+0.79%) ⬆️
client/daemon/transport/transport.go 59.48% <100.00%> (+0.71%) ⬆️
pkg/sync/kmutex.go 83.33% <0.00%> (-16.67%) ⬇️
pkg/sync/krwmutex.go 81.81% <0.00%> (-4.55%) ⬇️
client/daemon/peer/piece_broker.go 81.48% <0.00%> (-3.71%) ⬇️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 55350fe into main Jan 17, 2022
@gaius-qi gaius-qi deleted the feat/trace-https-request branch January 17, 2022 06:54
gaius-qi pushed a commit that referenced this pull request Jan 17, 2022
* feat: trace https proxy request

Signed-off-by: Jim Ma <[email protected]>

* fix: daemon test

Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Gaius <[email protected]>
yxxhero pushed a commit that referenced this pull request Jan 18, 2022
* feat: trace https proxy request (#996)

* feat: trace https proxy request

Signed-off-by: Jim Ma <[email protected]>

* fix: daemon test

Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Gaius <[email protected]>

* feat: remove sync kmutex and add task mutex

Signed-off-by: Gaius <[email protected]>

Co-authored-by: Jim Ma <[email protected]>
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: trace https proxy request

Signed-off-by: Jim Ma <[email protected]>

* fix: daemon test

Signed-off-by: Jim Ma <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: trace https proxy request (#996)

* feat: trace https proxy request

Signed-off-by: Jim Ma <[email protected]>

* fix: daemon test

Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Gaius <[email protected]>

* feat: remove sync kmutex and add task mutex

Signed-off-by: Gaius <[email protected]>

Co-authored-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants