Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schedulers send invalid direct piece #970

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 31, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Fix #968

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner December 31, 2021 06:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #970 (9fc3ed5) into main (35a005e) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   42.39%   42.47%   +0.07%     
==========================================
  Files         116      116              
  Lines        8796     8796              
==========================================
+ Hits         3729     3736       +7     
+ Misses       4600     4595       -5     
+ Partials      467      465       -2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.47% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 45.96% <0.00%> (-0.58%) ⬇️
client/daemon/peer/peertask_stream.go 56.65% <0.00%> (+2.16%) ⬆️
pkg/sync/krwmutex.go 86.36% <0.00%> (+4.54%) ⬆️
pkg/sync/kmutex.go 100.00% <0.00%> (+16.66%) ⬆️

hyy0322
hyy0322 previously approved these changes Dec 31, 2021
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma force-pushed the fix/schedulers-send-invalid-direct-piece branch from 67aea26 to 0bb75e4 Compare December 31, 2021 06:59
@jim3ma jim3ma force-pushed the fix/schedulers-send-invalid-direct-piece branch from 0bb75e4 to 9fc3ed5 Compare December 31, 2021 07:18
@jim3ma jim3ma merged commit edcdc9b into main Dec 31, 2021
@jim3ma jim3ma deleted the fix/schedulers-send-invalid-direct-piece branch December 31, 2021 07:38
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer seed from cdn failed, but task status is success
4 participants