-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useProxies to registryMirror allowing to mirror more anything #965
Add useProxies to registryMirror allowing to mirror more anything #965
Conversation
Codecov Report
@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 42.19% 42.33% +0.13%
==========================================
Files 116 116
Lines 8783 8788 +5
==========================================
+ Hits 3706 3720 +14
+ Misses 4609 4599 -10
- Partials 468 469 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a8bfbc7
to
55722d2
Compare
Signed-off-by: momiji <[email protected]>
Signed-off-by: momiji <[email protected]>
Signed-off-by: momiji <[email protected]>
55722d2
to
04a64ed
Compare
I apologize as I've never done this before, but I guess once used to the PR process, it will be easier and less a pain for me :) I've tested the fix and confirm is it working perfectly on my real environments, using the docker image built for this purpose on my github account. Will there be a v2.0.2 or v2.1.0 version including the fix soon? Not sure if including the alpha changes is necessary. |
Next release is v2.0.2. This change will be included. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ng (#965) * feat: add useProxies to registryMirror to allow mirroring anything Signed-off-by: momiji <[email protected]>
Description
Add a new field in registryMirror, allowing to use proxies list to decide whether to use dragonfly.
By doing this, it is now possible to cache more than only blobs/sha256 urls, allowing to use dragonfly2 for other usage thatn docker registries, like yum repositories.
Also fix the whiteList test which is tested on direct request, although host is empty and canno tbe tested.
Please update the documentation in Chinese, I just can't do it.
Related Issue
#959
Motivation and Context
This PR now allows to use dragonfly to mirror yum repositories, at least.
Screenshots (if appropriate):
Types of changes
Checklist: