Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change metrics service port to 8000 #964

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Change metrics service listen port to 8000.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Dec 29, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner December 29, 2021 09:05
@gaius-qi gaius-qi self-assigned this Dec 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #964 (985fb44) into main (c6b7ab9) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   42.33%   42.38%   +0.05%     
==========================================
  Files         116      116              
  Lines        8783     8783              
==========================================
+ Hits         3718     3723       +5     
+ Misses       4597     4591       -6     
- Partials      468      469       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.38% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdn/config/old_config.go 33.57% <0.00%> (ø)
cdn/metrics/config.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_base.go 45.96% <0.00%> (-1.16%) ⬇️
client/daemon/peer/peertask_stream.go 55.72% <0.00%> (+2.16%) ⬆️
cdn/supervisor/progress/progress.go 97.01% <0.00%> (+5.97%) ⬆️

@gaius-qi gaius-qi merged commit abfa0a3 into main Dec 29, 2021
@gaius-qi gaius-qi deleted the feature/cdn-metrics-port branch December 29, 2021 09:17
momiji pushed a commit to momiji/Dragonfly2 that referenced this pull request Dec 29, 2021
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants