Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy e2e proxy log to artifact #962

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Dec 27, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner December 27, 2021 12:49
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #962 (32d2f76) into main (f6b1fc7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   42.22%   42.22%           
=======================================
  Files         116      116           
  Lines        8783     8783           
=======================================
  Hits         3709     3709           
  Misses       4606     4606           
  Partials      468      468           
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 45.38% <0.00%> (ø)

hyy0322
hyy0322 previously approved these changes Dec 28, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c6b7ab9 into main Dec 28, 2021
@gaius-qi gaius-qi deleted the chore/e2e-copy-proxy-log branch December 28, 2021 03:55
momiji pushed a commit to momiji/Dragonfly2 that referenced this pull request Dec 29, 2021
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants