Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove ifaceutils #860

Merged
merged 1 commit into from
Dec 3, 2021
Merged

feat: remove ifaceutils #860

merged 1 commit into from
Dec 3, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Dec 3, 2021

Signed-off-by: Gaius [email protected]

Description

  • Remove ifaceutils pkg.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Dec 3, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner December 3, 2021 07:40
@gaius-qi gaius-qi self-assigned this Dec 3, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #860 (0cd91a5) into main (3f6e672) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   41.40%   41.30%   -0.11%     
==========================================
  Files         103      102       -1     
  Lines        8047     8038       -9     
==========================================
- Hits         3332     3320      -12     
- Misses       4304     4308       +4     
+ Partials      411      410       -1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 41.30% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 53.82% <0.00%> (-1.53%) ⬇️

@gaius-qi gaius-qi merged commit 2e2df97 into main Dec 3, 2021
@gaius-qi gaius-qi deleted the feature/remove-pkg branch December 3, 2021 07:57
gaius-qi added a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants