Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dfdaemon get scheduler list dynamically from manager #812

Merged
merged 5 commits into from
Nov 22, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 19, 2021

Signed-off-by: Gaius [email protected]

Description

  • Dfdaemon get scheduler list dynamically from manager.

Related Issue

Fixes #795

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Nov 19, 2021
@gaius-qi gaius-qi self-assigned this Nov 19, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner November 19, 2021 09:41
@gaius-qi gaius-qi changed the title docs: dfget add manager dynamic config feat: get scheduler list dynamically from manager Nov 19, 2021
@gaius-qi gaius-qi force-pushed the feature/client-dynconfig branch 4 times, most recently from 11e9a1a to 74e28e0 Compare November 22, 2021 08:59
@gaius-qi gaius-qi force-pushed the feature/client-dynconfig branch from 74e28e0 to 55af381 Compare November 22, 2021 12:11
@gaius-qi gaius-qi force-pushed the feature/client-dynconfig branch from 27479c8 to 0df4bc7 Compare November 22, 2021 12:24
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi changed the title feat: get scheduler list dynamically from manager feat: dfdaemon get scheduler list dynamically from manager Nov 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #812 (0ad7ad3) into main (ccde8e8) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   40.91%   40.86%   -0.06%     
==========================================
  Files          98       99       +1     
  Lines        7916     8027     +111     
==========================================
+ Hits         3239     3280      +41     
- Misses       4270     4338      +68     
- Partials      407      409       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 40.86% <33.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/peerhost.go 35.29% <0.00%> (-0.71%) ⬇️
client/daemon/daemon.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_dummy.go 0.00% <ø> (ø)
scheduler/config/dynconfig.go 39.83% <25.00%> (-0.53%) ⬇️
client/config/dynconfig.go 56.66% <56.66%> (ø)
internal/dynconfig/dynconfig_manager.go 72.41% <100.00%> (ø)
manager/searcher/searcher.go 62.26% <100.00%> (ø)
client/daemon/peer/peertask_base.go 47.27% <0.00%> (+1.21%) ⬆️

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/client-dynconfig branch from 0ad7ad3 to b8e9916 Compare November 22, 2021 13:08
@gaius-qi gaius-qi requested a review from xujihui1985 November 22, 2021 14:00
@gaius-qi gaius-qi merged commit 543a4a2 into main Nov 22, 2021
@gaius-qi gaius-qi deleted the feature/client-dynconfig branch November 22, 2021 14:01
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: dfdaemon get scheduler list dynamically from manager

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic scheduler list for dfget
4 participants