Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preheat test #794

Merged
merged 1 commit into from
Nov 13, 2021
Merged

feat: preheat test #794

merged 1 commit into from
Nov 13, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Fix preheat test.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.1 milestone Nov 13, 2021
@gaius-qi gaius-qi self-assigned this Nov 13, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner November 13, 2021 08:37
@codecov-commenter
Copy link

Codecov Report

Merging #794 (ded4379) into main (0dfadbb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
- Coverage   40.31%   40.28%   -0.03%     
==========================================
  Files          94       94              
  Lines        7787     7787              
==========================================
- Hits         3139     3137       -2     
- Misses       4242     4244       +2     
  Partials      406      406              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 40.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 53.82% <0.00%> (-1.53%) ⬇️
client/daemon/peer/peertask_base.go 47.56% <0.00%> (+0.60%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 10ff474 into main Nov 13, 2021
@gaius-qi gaius-qi deleted the fix/preheat-test branch November 13, 2021 09:01
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants