Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add manager client list scheduler interface #694

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Add manager client list scheduler interface.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.1 milestone Sep 28, 2021
@gaius-qi gaius-qi self-assigned this Sep 28, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner September 28, 2021 08:53
@codecov-commenter
Copy link

Codecov Report

Merging #694 (807fb64) into main (89b42c4) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
+ Coverage   38.50%   38.54%   +0.04%     
==========================================
  Files          89       89              
  Lines        6987     6987              
==========================================
+ Hits         2690     2693       +3     
+ Misses       3912     3909       -3     
  Partials      385      385              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 34.28% <0.00%> (+0.61%) ⬆️

@gaius-qi gaius-qi merged commit e9fdf71 into main Sep 28, 2021
@gaius-qi gaius-qi deleted the feature/manager-list-schedulers branch September 28, 2021 10:18
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: add manager client list scheduler interface

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants