Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print version information when system starts up #620

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Conversation

244372610
Copy link
Contributor

Signed-off-by: santong [email protected]

Description

Print version information when the system starts up

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@244372610 244372610 requested a review from a team as a code owner September 8, 2021 04:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #620 (a0679e9) into main (cc6253c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   38.44%   38.42%   -0.02%     
==========================================
  Files          88       88              
  Lines        6969     6969              
==========================================
- Hits         2679     2678       -1     
+ Misses       3911     3909       -2     
- Partials      379      382       +3     
Flag Coverage Δ
unittests 38.42% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream_callback.go 59.77% <0.00%> (-2.30%) ⬇️
client/daemon/peer/peertask_base.go 33.06% <0.00%> (-0.62%) ⬇️
client/daemon/peer/peertask_stream.go 56.95% <0.00%> (+1.29%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require Unittest??

@244372610 244372610 changed the title Print version information when the system starts up Print version information when system starts up Sep 8, 2021
gaius-qi
gaius-qi previously approved these changes Sep 8, 2021
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jim3ma
jim3ma previously approved these changes Sep 8, 2021
Signed-off-by: santong <[email protected]>
@244372610 244372610 dismissed stale reviews from jim3ma and gaius-qi via a0679e9 September 8, 2021 07:59
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 4f44c13 into main Sep 8, 2021
@gaius-qi gaius-qi deleted the feature/printVersion branch September 8, 2021 10:31
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants