Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: refresh proto file #615

Merged
merged 1 commit into from
Sep 7, 2021
Merged

feature: refresh proto file #615

merged 1 commit into from
Sep 7, 2021

Conversation

garfield009
Copy link
Collaborator

Signed-off-by: zuozheng.hzz [email protected]

Description

Related Issue

#614

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: zuozheng.hzz <[email protected]>
@garfield009 garfield009 requested a review from a team as a code owner September 7, 2021 09:45
@codecov-commenter
Copy link

Codecov Report

Merging #615 (08ad55b) into main (0569053) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   38.51%   38.49%   -0.02%     
==========================================
  Files          88       88              
  Lines        6969     6969              
==========================================
- Hits         2684     2683       -1     
  Misses       3906     3906              
- Partials      379      380       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 38.49% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 33.06% <0.00%> (-0.62%) ⬇️
client/daemon/peer/peertask_stream.go 57.92% <0.00%> (+0.64%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 023f18f into main Sep 7, 2021
@gaius-qi gaius-qi deleted the feature/refresh-proto branch September 7, 2021 10:08
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants