Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start process #572

Merged
merged 11 commits into from
Aug 25, 2021
Merged

feat: start process #572

merged 11 commits into from
Aug 25, 2021

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 25, 2021

Description

  • Scheduler start process.
  • CDN start process.
  • Keepalive retry.
  • Manager grpc request timeout and backoff config.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 25, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner August 25, 2021 02:36
@gaius-qi gaius-qi self-assigned this Aug 25, 2021
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi changed the title Feature/scheduler start feat: start process Aug 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #572 (d1d574b) into main (64e83a9) will increase coverage by 0.08%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   39.04%   39.12%   +0.08%     
==========================================
  Files          86       86              
  Lines        6644     6655      +11     
==========================================
+ Hits         2594     2604      +10     
- Misses       3678     3681       +3     
+ Partials      372      370       -2     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.12% <11.76%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/job/job.go 16.66% <0.00%> (-4.49%) ⬇️
scheduler/config/config.go 4.59% <0.00%> (+0.15%) ⬆️
scheduler/config/dynconfig.go 56.79% <100.00%> (ø)
client/daemon/peer/peertask_base.go 34.68% <0.00%> (ø)
client/daemon/peer/peertask_stream_callback.go 64.55% <0.00%> (+2.53%) ⬆️
client/daemon/peer/peertask_stream.go 56.79% <0.00%> (+2.78%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit f0f55db into main Aug 25, 2021
@gaius-qi gaius-qi deleted the feature/scheduler-start branch August 25, 2021 11:38
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: server start process

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants