Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: update helm charts submodule #567

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Feature: update helm charts submodule #567

merged 2 commits into from
Aug 20, 2021

Conversation

gaius-qi
Copy link
Member

Description

  • Update helm charts submodule.
  • Docker push workflow with submodule.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.0 milestone Aug 20, 2021
@gaius-qi gaius-qi self-assigned this Aug 20, 2021
@gaius-qi gaius-qi requested review from a team as code owners August 20, 2021 09:50
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #567 (c7efeb2) into main (fb54969) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   39.25%   39.18%   -0.08%     
==========================================
  Files          86       86              
  Lines        6641     6641              
==========================================
- Hits         2607     2602       -5     
- Misses       3665     3669       +4     
- Partials      369      370       +1     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.18% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 55.05% <0.00%> (-1.05%) ⬇️
client/daemon/peer/piece_manager.go 67.19% <0.00%> (-0.80%) ⬇️

@gaius-qi gaius-qi merged commit c34a6e7 into main Aug 20, 2021
@gaius-qi gaius-qi deleted the feature/helm-charts branch August 20, 2021 10:07
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: update submodule

Signed-off-by: Gaius <[email protected]>

* chore: docker build with submodules

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps [clap](https://github.com/clap-rs/clap) from 4.5.7 to 4.5.8.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@clap_complete-v4.5.7...v4.5.8)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants