Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Log #495

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Schedule Log #495

merged 4 commits into from
Jul 26, 2021

Conversation

244372610
Copy link
Contributor

Description

Add schedule execute detail log

Related Issue

fix #494

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@244372610 244372610 requested a review from a team as a code owner July 26, 2021 03:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #495 (d5e482f) into main (c0e41ea) will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   39.44%   39.71%   +0.27%     
==========================================
  Files          81       81              
  Lines        6284     6284              
==========================================
+ Hits         2479     2496      +17     
+ Misses       3444     3430      -14     
+ Partials      361      358       -3     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 39.71% <ø> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 32.70% <0.00%> (+0.47%) ⬆️
client/daemon/peer/peertask_stream.go 59.92% <0.00%> (+4.04%) ⬆️
client/daemon/peer/peertask_stream_callback.go 67.08% <0.00%> (+5.06%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 2b18530 into main Jul 26, 2021
@gaius-qi gaius-qi deleted the feature/schedulerLog branch July 26, 2021 07:35
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: add bad node log

Signed-off-by: santong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler detail log
4 participants