Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search scheduler cluster #462

Merged
merged 13 commits into from
Jul 16, 2021
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jul 15, 2021

Description

  • Add search.SchedulerCluster to choose the optimal schedulers.
  • Add search plugin to provide custom search methods.

Related Issue

Fixes #456

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

gaius-qi added 8 commits July 13, 2021 21:23
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 15, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 15, 2021 06:49
@gaius-qi gaius-qi self-assigned this Jul 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #462 (79c9c3c) into main (b2ca351) will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   36.38%   36.39%   +0.01%     
==========================================
  Files          86       89       +3     
  Lines        6869     6959      +90     
==========================================
+ Hits         2499     2533      +34     
- Misses       4005     4057      +52     
- Partials      365      369       +4     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.39% <77.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
manager/searcher/plugin.go 50.00% <50.00%> (ø)
manager/searcher/search.go 82.05% <82.05%> (ø)
client/daemon/peer/peertask_stream_callback.go 62.02% <0.00%> (-2.54%) ⬇️
manager/config/config.go 0.00% <0.00%> (ø)
client/daemon/peer/peertask_stream.go 55.14% <0.00%> (+0.36%) ⬆️

manager/search/search.go Outdated Show resolved Hide resolved
manager/search/testdata/plugin/search.go Outdated Show resolved Hide resolved
@gaius-qi gaius-qi merged commit 7659def into main Jul 16, 2021
@gaius-qi gaius-qi deleted the feature/search-scheduler-cluster branch July 16, 2021 05:37
@gaius-qi gaius-qi changed the title Feature/search scheduler cluster feat: search scheduler cluster Jul 17, 2021
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: add searcher

Signed-off-by: Gaius <[email protected]>
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.57 to 1.0.60.
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](dtolnay/thiserror@1.0.57...1.0.60)

---
updated-dependencies:
- dependency-name: thiserror
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match schedulers according to client information
4 participants