Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add host info for scheduler and cdn #457

Merged
merged 1 commit into from
Jul 13, 2021
Merged

feat: add host info for scheduler and cdn #457

merged 1 commit into from
Jul 13, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Get host info from config.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 12, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 12, 2021 12:28
@gaius-qi gaius-qi self-assigned this Jul 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #457 (7dd0ba3) into main (b7b4558) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   36.31%   36.28%   -0.03%     
==========================================
  Files          85       85              
  Lines        6727     6727              
==========================================
- Hits         2443     2441       -2     
- Misses       3933     3935       +2     
  Partials      351      351              
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <ø> (ø)
client/daemon/peer/peertask_stream.go 54.77% <0.00%> (-2.21%) ⬇️
client/daemon/peer/peertask_base.go 33.89% <0.00%> (+0.95%) ⬆️

@jim3ma jim3ma merged commit 2c5fc97 into main Jul 13, 2021
@jim3ma jim3ma deleted the feature/host-info branch July 13, 2021 02:05
@jim3ma jim3ma changed the title feat: host info feat: add host info for scheduler and cdn Jul 13, 2021
gaius-qi added a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants