Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manager user typo #453

Merged
merged 1 commit into from
Jul 12, 2021
Merged

fix: manager user typo #453

merged 1 commit into from
Jul 12, 2021

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Rename Bio to BIO

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi added this to the v2.0.0 milestone Jul 12, 2021
@gaius-qi gaius-qi self-assigned this Jul 12, 2021
@gaius-qi gaius-qi requested a review from a team as a code owner July 12, 2021 05:33
@gaius-qi gaius-qi changed the title fix: user bio typo fix: manager user typo Jul 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #453 (2b10e4f) into main (bfd44c1) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   36.25%   36.28%   +0.02%     
==========================================
  Files          85       85              
  Lines        6724     6724              
==========================================
+ Hits         2438     2440       +2     
  Misses       3933     3933              
+ Partials      353      351       -2     
Flag Coverage Δ
e2etests ∅ <ø> (∅)
unittests 36.28% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 32.21% <0.00%> (-0.72%) ⬇️
client/daemon/peer/peertask_stream.go 56.98% <0.00%> (+1.10%) ⬆️
client/daemon/peer/peertask_stream_callback.go 64.55% <0.00%> (+2.53%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 90db0fd into main Jul 12, 2021
@gaius-qi gaius-qi deleted the feature/manager-user branch July 12, 2021 06:21
gaius-qi added a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants