Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize error message for proxy #428

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jul 6, 2021

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner July 6, 2021 10:13
@jim3ma jim3ma requested review from bergwolf, ansinlee and 244372610 July 6, 2021 10:13
@jim3ma jim3ma force-pushed the feature/optmize-error-message branch from c2c4929 to 98879a8 Compare July 6, 2021 10:13
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #428 (c2c4929) into main (54c4bf8) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

❗ Current head c2c4929 differs from pull request most recent head 98879a8. Consider uploading reports for the commit 98879a8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   38.24%   38.11%   -0.14%     
==========================================
  Files          80       80              
  Lines        6212     6224      +12     
==========================================
- Hits         2376     2372       -4     
- Misses       3500     3517      +17     
+ Partials      336      335       -1     
Flag Coverage Δ
unittests 38.11% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 54.61% <0.00%> (-1.24%) ⬇️
client/daemon/proxy/proxy.go 8.04% <0.00%> (-0.10%) ⬇️
client/daemon/transport/transport.go 75.53% <0.00%> (-2.50%) ⬇️
client/daemon/peer/peertask_base.go 33.49% <0.00%> (-0.98%) ⬇️

@jim3ma jim3ma merged commit 0907648 into main Jul 7, 2021
@jim3ma jim3ma deleted the feature/optmize-error-message branch July 7, 2021 09:22
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants