Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong cache task header #423

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix wrong cache task header #423

merged 1 commit into from
Jul 5, 2021

Conversation

244372610
Copy link
Contributor

@244372610 244372610 commented Jul 5, 2021

Signed-off-by: santong [email protected]

Description

Related Issue

fix #424

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@244372610 244372610 requested a review from a team as a code owner July 5, 2021 08:24
@codecov-commenter
Copy link

Codecov Report

Merging #423 (9a85fa7) into main (bb3c0f3) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   38.44%   38.49%   +0.04%     
==========================================
  Files          80       80              
  Lines        6211     6212       +1     
==========================================
+ Hits         2388     2391       +3     
+ Misses       3486     3483       -3     
- Partials      337      338       +1     
Flag Coverage Δ
unittests 38.49% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cdnsystem/daemon/task/manager_util.go 0.00% <0.00%> (ø)
pkg/source/httpprotocol/http_source_client.go 69.86% <0.00%> (ø)
pkg/source/source_client.go 0.00% <ø> (ø)
client/daemon/peer/peertask_base.go 32.76% <0.00%> (-0.73%) ⬇️
client/daemon/peer/peertask_stream.go 58.11% <0.00%> (+2.26%) ⬆️

@244372610 244372610 added this to the v2.0.0 milestone Jul 5, 2021
@jim3ma jim3ma merged commit 54c4bf8 into main Jul 5, 2021
@jim3ma jim3ma deleted the feature/cdnHeaderExpire branch July 5, 2021 09:07
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
e-ngo pushed a commit to e-ngo/dragonfly that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair wrong task cache header
4 participants