Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add seed peer e2e compatibility test #1358

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Jun 1, 2022

Signed-off-by: Gaius [email protected]

Description

  • Add seed peer e2e compatibility test.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone Jun 1, 2022
@gaius-qi gaius-qi self-assigned this Jun 1, 2022
@gaius-qi gaius-qi requested review from a team as code owners June 1, 2022 10:55
@gaius-qi gaius-qi force-pushed the feature/e2e-seed-peer branch from e34bd28 to c5d7cf4 Compare June 1, 2022 11:51
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/e2e-seed-peer branch from c5d7cf4 to 625166c Compare June 1, 2022 12:09
@codecov-commenter
Copy link

Codecov Report

Merging #1358 (625166c) into main (20d05f5) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1358      +/-   ##
==========================================
+ Coverage   45.46%   45.66%   +0.19%     
==========================================
  Files         140      140              
  Lines       11981    11984       +3     
==========================================
+ Hits         5447     5472      +25     
+ Misses       5910     5885      -25     
- Partials      624      627       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.66% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/transport/transport.go 49.33% <0.00%> (-1.01%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 47.61% <0.00%> (+0.86%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 47.10% <0.00%> (+16.66%) ⬆️

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 3463494 into main Jun 1, 2022
@gaius-qi gaius-qi deleted the feature/e2e-seed-peer branch June 1, 2022 12:42
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants