Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change pattern from cdn to seed peer #1345

Merged
merged 3 commits into from
May 31, 2022

Conversation

gaius-qi
Copy link
Member

Description

  • Change pattern from cdn to seed peer.
  • Remove kustomize shell.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone May 31, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner May 31, 2022 04:34
@gaius-qi gaius-qi self-assigned this May 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #1345 (d60652b) into main (0ed03d1) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1345      +/-   ##
==========================================
- Coverage   45.84%   45.44%   -0.41%     
==========================================
  Files         140      140              
  Lines       11967    11967              
==========================================
- Hits         5486     5438      -48     
- Misses       5862     5908      +46     
- Partials      619      621       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
unittests 45.44% <0.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/dfget.go 29.06% <ø> (ø)
client/config/peerhost.go 33.21% <0.00%> (ø)
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-20.29%) ⬇️
cdn/supervisor/progress/progress.go 90.62% <0.00%> (-6.25%) ⬇️
client/daemon/rpcserver/subscriber.go 48.85% <0.00%> (-2.30%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 47.61% <0.00%> (-1.30%) ⬇️
client/daemon/peer/peertask_conductor.go 57.31% <0.00%> (-1.01%) ⬇️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit abf95a9 into main May 31, 2022
@gaius-qi gaius-qi deleted the feature/pattern-with-seed-peer branch May 31, 2022 06:17
gaius-qi added a commit that referenced this pull request Jun 28, 2023
…#1345)

* feat: change pattern from cdn to seed peer and remove kustomize shell

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants