Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker build with multi platforms #1337

Merged
merged 3 commits into from
May 26, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Docker build with multi platforms.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone May 26, 2022
@gaius-qi gaius-qi self-assigned this May 26, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner May 26, 2022 06:08
cndoit18
cndoit18 previously approved these changes May 26, 2022
Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Gaius <[email protected]>
cndoit18
cndoit18 previously approved these changes May 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #1337 (e1af9f2) into main (eff00c0) will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
- Coverage   45.69%   45.46%   -0.24%     
==========================================
  Files         140      140              
  Lines       11950    11950              
==========================================
- Hits         5461     5433      -28     
- Misses       5871     5899      +28     
  Partials      618      618              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.46% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 47.61% <0.00%> (-1.30%) ⬇️
client/daemon/peer/peertask_conductor.go 57.31% <0.00%> (-0.21%) ⬇️

cndoit18
cndoit18 previously approved these changes May 26, 2022
@gaius-qi gaius-qi force-pushed the feature/docker-build-with-multi-platforms branch from 721e4f4 to bcfcf2b Compare May 26, 2022 06:28
KubeStacker
KubeStacker previously approved these changes May 26, 2022
Copy link
Member

@KubeStacker KubeStacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cndoit18
cndoit18 previously approved these changes May 26, 2022
@gaius-qi gaius-qi dismissed stale reviews from cndoit18 and KubeStacker via eaaa113 May 26, 2022 06:53
@gaius-qi gaius-qi force-pushed the feature/docker-build-with-multi-platforms branch 3 times, most recently from e1af9f2 to 9522e85 Compare May 26, 2022 09:37
Signed-off-by: Gaius <[email protected]>
@gaius-qi gaius-qi force-pushed the feature/docker-build-with-multi-platforms branch from 9522e85 to 60619d1 Compare May 26, 2022 09:49
@gaius-qi gaius-qi merged commit e58a111 into main May 26, 2022
@gaius-qi gaius-qi deleted the feature/docker-build-with-multi-platforms branch May 26, 2022 10:08
gaius-qi added a commit that referenced this pull request May 26, 2022
* feat: docker build with multi platforms

Signed-off-by: Gaius <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: docker build with multi platforms

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants