Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce dynconfig logs #1312

Merged
merged 1 commit into from
May 18, 2022
Merged

feat: reduce dynconfig logs #1312

merged 1 commit into from
May 18, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Reduce dynconfig logs.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone May 18, 2022
@gaius-qi gaius-qi self-assigned this May 18, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner May 18, 2022 04:12
@gaius-qi gaius-qi requested review from yxxhero, eryugey and bigerous May 18, 2022 04:12
@codecov-commenter
Copy link

Codecov Report

Merging #1312 (4824b9c) into main (7610d47) will decrease coverage by 0.21%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
- Coverage   45.71%   45.50%   -0.22%     
==========================================
  Files         140      140              
  Lines       11890    11890              
==========================================
- Hits         5436     5411      -25     
- Misses       5840     5868      +28     
+ Partials      614      611       -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.50% <60.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/daemon.go 5.72% <0.00%> (-0.02%) ⬇️
scheduler/resource/seed_peer_client.go 69.56% <100.00%> (-0.33%) ⬇️
client/daemon/peer/peertask_piecetask_poller.go 30.43% <0.00%> (-16.67%) ⬇️
client/daemon/peer/piece_broker.go 89.74% <0.00%> (-2.57%) ⬇️

@yxxhero yxxhero merged commit b580ea6 into main May 18, 2022
@yxxhero yxxhero deleted the feature/dynconfig branch May 18, 2022 05:53
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants