feat: add vsock network type support #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eryugey
force-pushed
the
for-upstream
branch
3 times, most recently
from
54823ad to
6f87b99
Compare
So we support connecting dfdaemon running on host outside of VM via virtio-vsock device. Signed-off-by: Eryu Guan <[email protected]>
eryugey
added a commit
to eryugey/Dragonfly2
that referenced
this pull request
May 31, 2022
Since commit 0bc0d3b ("feat: add vsock network type support (dragonflyoss#1303)") we have vsock support, which means we could run dfget in a constrained VM env that only has loopback net interface, and connect to dfdaemon on host via vsock connection. So it's a valid setup to have no external IPv4 addr. Don't panic in this case and use "127.0.0.1" as IPv4. Signed-off-by: Eryu Guan <[email protected]>
8 tasks
eryugey
added a commit
to eryugey/Dragonfly2
that referenced
this pull request
May 31, 2022
Since commit 0bc0d3b ("feat: add vsock network type support (dragonflyoss#1303)") we have vsock support, which means we could run dfget in a constrained VM env that only has loopback net interface, and connect to dfdaemon on host via vsock connection. So it's a valid setup to have no external IPv4 addr. Don't panic in this case and use "127.0.0.1" as IPv4. Signed-off-by: Eryu Guan <[email protected]>
eryugey
added a commit
to eryugey/Dragonfly2
that referenced
this pull request
May 31, 2022
Since commit 0bc0d3b ("feat: add vsock network type support (dragonflyoss#1303)") we have vsock support, which means we could run dfget in a constrained VM env that only has loopback net interface, and connect to dfdaemon on host via vsock connection. So it's a valid setup to have no external IPv4 addr. Don't panic in this case and use "127.0.0.1" as IPv4. Signed-off-by: Eryu Guan <[email protected]>
eryugey
added a commit
to eryugey/Dragonfly2
that referenced
this pull request
May 31, 2022
Since commit 0bc0d3b ("feat: add vsock network type support (dragonflyoss#1303)") we have vsock support, which means we could run dfget in a constrained VM env that only has loopback net interface, and connect to dfdaemon on host via vsock connection. So it's a valid setup to have no external IPv4 addr. Don't panic in this case and use "127.0.0.1" as IPv4. Signed-off-by: Eryu Guan <[email protected]>
gaius-qi
added a commit
that referenced
this pull request
Jun 1, 2022
* feat: use 127.0.0.1 as IPv4 if there's no external IPv4 addr Since commit 0bc0d3b ("feat: add vsock network type support (#1303)") we have vsock support, which means we could run dfget in a constrained VM env that only has loopback net interface, and connect to dfdaemon on host via vsock connection. So it's a valid setup to have no external IPv4 addr. Don't panic in this case and use "127.0.0.1" as IPv4. Signed-off-by: Eryu Guan <[email protected]> * Update ip_utils.go * Update ip_utils.go Co-authored-by: Gaius <[email protected]>
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
So we support connecting dfdaemon running on host outside of VM via virtio-vsock device. Signed-off-by: Eryu Guan <[email protected]>
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
* feat: use 127.0.0.1 as IPv4 if there's no external IPv4 addr Since commit 0bc0d3b ("feat: add vsock network type support (#1303)") we have vsock support, which means we could run dfget in a constrained VM env that only has loopback net interface, and connect to dfdaemon on host via vsock connection. So it's a valid setup to have no external IPv4 addr. Don't panic in this case and use "127.0.0.1" as IPv4. Signed-off-by: Eryu Guan <[email protected]> * Update ip_utils.go * Update ip_utils.go Co-authored-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we support connecting dfdaemon running on host outside of VM via
virtio-vsock device.
Signed-off-by: Eryu Guan [email protected]
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist