feat: don't gc client rpc connection if ExpireTime is 0 #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we don't want to GC client connections in some special circumstances. Signed-off-by: Eryu Guan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1296 +/- ##
==========================================
- Coverage 46.33% 46.12% -0.22%
==========================================
Files 137 137
Lines 11625 11625
==========================================
- Hits 5387 5362 -25
- Misses 5649 5667 +18
- Partials 589 596 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
In case we don't want to GC client connections in some special circumstances. Signed-off-by: Eryu Guan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we don't want to GC client connections in some special
circumstances.
Signed-off-by: Eryu Guan [email protected]
Types of changes
Checklist