Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in tree plugin #1276

Merged
merged 2 commits into from
Apr 24, 2022
Merged

feat: in tree plugin #1276

merged 2 commits into from
Apr 24, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 24, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner April 24, 2022 04:47
@jim3ma jim3ma force-pushed the feat/in-tree-plugin branch from 3ab7ba3 to 37e861d Compare April 24, 2022 04:48
Signed-off-by: Jim Ma <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #1276 (57ebea6) into main (0ca681c) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   45.90%   45.79%   -0.12%     
==========================================
  Files         135      135              
  Lines       11341    11353      +12     
==========================================
- Hits         5206     5199       -7     
- Misses       5569     5586      +17     
- Partials      566      568       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.79% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../source/clients/hdfsprotocol/hdfs_source_client.go 53.26% <ø> (ø)
.../source/clients/httpprotocol/http_source_client.go 65.74% <ø> (ø)
pkg/source/source_client.go 1.75% <0.00%> (-0.10%) ⬇️
cdn/supervisor/progress/progress.go 90.62% <0.00%> (-6.25%) ⬇️
scheduler/config/config.go 47.41% <0.00%> (-2.59%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 44.84% <0.00%> (-1.55%) ⬇️

Signed-off-by: Jim Ma <[email protected]>
Copy link
Contributor

@anjia0532 anjia0532 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d318041 into main Apr 24, 2022
@gaius-qi gaius-qi deleted the feat/in-tree-plugin branch April 24, 2022 06:31
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: in tree plugin

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants