Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tree infinite loop #1271

Merged
merged 3 commits into from
Apr 22, 2022
Merged

fix: tree infinite loop #1271

merged 3 commits into from
Apr 22, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Fix tree infinite loop.
  • When there is no CDN, the peer back-to-source immediately.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.0.3 milestone Apr 21, 2022
@gaius-qi gaius-qi self-assigned this Apr 21, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner April 21, 2022 14:19
@gaius-qi gaius-qi force-pushed the feature/scheduler branch from 96b65d2 to 17c8b11 Compare April 21, 2022 14:21
KubeStacker
KubeStacker previously approved these changes Apr 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1271 (2e79ff1) into main (5b5d9a7) will increase coverage by 0.08%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   45.87%   45.96%   +0.08%     
==========================================
  Files         135      135              
  Lines       11317    11341      +24     
==========================================
+ Hits         5192     5213      +21     
+ Misses       5559     5554       -5     
- Partials      566      574       +8     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.96% <97.77%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/peer.go 77.83% <96.66%> (+1.16%) ⬆️
scheduler/scheduler/scheduler.go 79.87% <100.00%> (-9.53%) ⬇️
scheduler/service/service.go 86.15% <100.00%> (+0.06%) ⬆️
cdn/supervisor/progress/progress.go 90.62% <0.00%> (-6.25%) ⬇️
client/daemon/peer/peertask_conductor.go 57.21% <0.00%> (-1.05%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 44.84% <0.00%> (+2.57%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 47.10% <0.00%> (+16.66%) ⬆️

hyy0322
hyy0322 previously approved these changes Apr 22, 2022
@gaius-qi gaius-qi force-pushed the feature/scheduler branch from 6901929 to 3737b11 Compare April 22, 2022 04:46
@gaius-qi gaius-qi merged commit 0ca681c into main Apr 22, 2022
@gaius-qi gaius-qi deleted the feature/scheduler branch April 22, 2022 06:20
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* fix: peer tree infinite loop

Signed-off-by: Gaius <[email protected]>

* feat: peer add Ancestors func

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants