Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client synchronizer report error lock and dial grpc timeout #1260

Merged
merged 7 commits into from
Apr 21, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 18, 2022

Description

  1. Cancel the peer task in background when encounter report to scheduler err in sync manager
  2. Remove superfluous retry to sync and get pieces from other peers to make sync pieces quickly.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@jim3ma jim3ma requested a review from a team as a code owner April 18, 2022 07:47
@jim3ma jim3ma changed the title fix: client synchronizer report error lock fix: client synchronizer report error lock and timeout Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1260 (fe7b4d5) into main (96bdf9f) will decrease coverage by 0.15%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
- Coverage   46.11%   45.96%   -0.16%     
==========================================
  Files         135      135              
  Lines       11245    11269      +24     
==========================================
- Hits         5186     5180       -6     
- Misses       5486     5522      +36     
+ Partials      573      567       -6     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.96% <50.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ent/daemon/peer/peertask_piecetask_synchronizer.go 43.24% <17.64%> (-1.39%) ⬇️
client/daemon/peer/peertask_piecetask_poller.go 47.10% <25.00%> (-6.24%) ⬇️
client/daemon/peer/peertask_conductor.go 57.35% <84.21%> (-0.80%) ⬇️

@jim3ma jim3ma changed the title fix: client synchronizer report error lock and timeout fix: client synchronizer report error lock and dial grpc timeout Apr 19, 2022
@KubeStacker
Copy link
Member

KubeStacker commented Apr 19, 2022

LGTM

KubeStacker
KubeStacker previously approved these changes Apr 19, 2022
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 76ad8cf into main Apr 21, 2022
@jim3ma jim3ma deleted the fix/client-synchronizer-report-error-lock branch April 21, 2022 04:42
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* fix: client synchronizer report error lock
* chore: remove superfluous retry to sync and get pieces from other peers
* chore: optimize back source and sync piece logic
* chore: print apk output in e2e
* fix: grpc send with io.EOF error

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants