-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: client synchronizer report error lock and dial grpc timeout #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
jim3ma
changed the title
fix: client synchronizer report error lock
fix: client synchronizer report error lock and timeout
Apr 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
- Coverage 46.11% 45.96% -0.16%
==========================================
Files 135 135
Lines 11245 11269 +24
==========================================
- Hits 5186 5180 -6
- Misses 5486 5522 +36
+ Partials 573 567 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
jim3ma
changed the title
fix: client synchronizer report error lock and timeout
fix: client synchronizer report error lock and dial grpc timeout
Apr 19, 2022
LGTM |
KubeStacker
approved these changes
Apr 19, 2022
KubeStacker
previously approved these changes
Apr 19, 2022
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
gaius-qi
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
244372610
approved these changes
Apr 21, 2022
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
* fix: client synchronizer report error lock * chore: remove superfluous retry to sync and get pieces from other peers * chore: optimize back source and sync piece logic * chore: print apk output in e2e * fix: grpc send with io.EOF error Signed-off-by: Jim Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist