Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement client seed mode #1247

Merged
merged 6 commits into from
May 6, 2022
Merged

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 13, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner April 13, 2022 14:24
@jim3ma jim3ma requested review from imeoer, hyy0322 and qwtsc April 13, 2022 14:24
@jim3ma jim3ma force-pushed the feat/implement-client-seed-mode branch from 4f3cb0f to 645c096 Compare April 19, 2022 10:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #1247 (5f30a00) into main (798ebb7) will increase coverage by 0.16%.
The diff coverage is 52.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
+ Coverage   46.04%   46.21%   +0.16%     
==========================================
  Files         135      137       +2     
  Lines       11370    11616     +246     
==========================================
+ Hits         5235     5368     +133     
- Misses       5563     5658      +95     
- Partials      572      590      +18     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.21% <52.34%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/proxy/proxy.go 13.12% <0.00%> (ø)
client/daemon/rpcserver/rpcserver.go 21.47% <13.33%> (-0.48%) ⬇️
client/daemon/storage/local_storage.go 28.96% <16.66%> (+0.23%) ⬆️
client/daemon/peer/peertask_reuse.go 71.15% <24.44%> (-12.90%) ⬇️
client/daemon/peer/peertask_manager.go 23.66% <43.75%> (+0.39%) ⬆️
client/daemon/rpcserver/seeder.go 62.09% <62.09%> (ø)
client/daemon/peer/peertask_file.go 57.57% <66.66%> (-0.12%) ⬇️
client/daemon/peer/peertask_conductor.go 57.84% <80.00%> (-0.43%) ⬇️
client/daemon/peer/peertask_seed.go 88.88% <88.88%> (ø)
client/daemon/peer/peertask_stream.go 62.67% <100.00%> (ø)
... and 4 more

@jim3ma jim3ma changed the title [WIP] feat: implement client seed mode feat: implement client seed mode Apr 28, 2022
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaius-qi gaius-qi merged commit 78600de into main May 6, 2022
@gaius-qi gaius-qi deleted the feat/implement-client-seed-mode branch May 6, 2022 03:03
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: implement client seed mode

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants