Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement pattern in client daemon #1231

Merged
merged 2 commits into from
May 12, 2022
Merged

feat: implement pattern in client daemon #1231

merged 2 commits into from
May 12, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 7, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner April 7, 2022 08:45
@jim3ma jim3ma requested review from 244372610, hyy0322 and qwtsc April 7, 2022 08:45
@codecov-commenter
Copy link

Codecov Report

Merging #1231 (79c27e7) into main (f685974) will decrease coverage by 0.66%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   46.62%   45.96%   -0.67%     
==========================================
  Files         133      133              
  Lines       10584    10613      +29     
==========================================
- Hits         4935     4878      -57     
- Misses       5092     5186      +94     
+ Partials      557      549       -8     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.96% <8.33%> (-0.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/config/peerhost.go 33.21% <0.00%> (-1.95%) ⬇️
client/daemon/daemon.go 6.37% <0.00%> (-0.06%) ⬇️
client/daemon/peer/peertask_file.go 57.36% <ø> (-0.33%) ⬇️
client/daemon/peer/peertask_stream.go 62.67% <ø> (ø)
client/daemon/proxy/proxy_manager.go 0.00% <0.00%> (ø)
client/daemon/transport/transport.go 50.34% <0.00%> (-1.05%) ⬇️
client/daemon/proxy/proxy.go 13.27% <25.00%> (+0.14%) ⬆️
client/daemon/rpcserver/rpcserver.go 37.41% <33.33%> (-0.49%) ⬇️
client/daemon/peer/peertask_manager.go 30.89% <50.00%> (+0.31%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 30.37% <0.00%> (-22.97%) ⬇️
... and 2 more

244372610
244372610 previously approved these changes May 11, 2022
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit b5de837 into main May 12, 2022
@gaius-qi gaius-qi deleted the feat/client-pattern branch May 12, 2022 09:34
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants