Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update manager console commit #1219

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Apr 1, 2022

Signed-off-by: Gaius [email protected]

Description

  • Update manager console commit.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Apr 1, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner April 1, 2022 04:21
@gaius-qi gaius-qi self-assigned this Apr 1, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1219 (0179623) into main (535d717) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
+ Coverage   46.02%   46.42%   +0.39%     
==========================================
  Files         133      133              
  Lines       10566    10566              
==========================================
+ Hits         4863     4905      +42     
+ Misses       5156     5105      -51     
- Partials      547      556       +9     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.42% <ø> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_conductor.go 57.18% <0.00%> (+1.20%) ⬆️
client/daemon/peer/peertask_piecetask_poller.go 53.33% <0.00%> (+22.96%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit bdca38b into main Apr 1, 2022
@gaius-qi gaius-qi deleted the feature/update-console branch April 1, 2022 04:33
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants