Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cannot delete a cluster with existing instances #1213

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Cannot delete a cluster with existing instances.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 30, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 30, 2022 14:21
@gaius-qi gaius-qi self-assigned this Mar 30, 2022
@gaius-qi gaius-qi requested review from imeoer, 244372610 and zzy987 March 30, 2022 14:21
@codecov-commenter
Copy link

Codecov Report

Merging #1213 (cecc917) into main (f613a8a) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   46.60%   46.44%   -0.17%     
==========================================
  Files         133      133              
  Lines       10556    10556              
==========================================
- Hits         4920     4903      -17     
- Misses       5082     5098      +16     
- Partials      554      555       +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.44% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ent/daemon/peer/peertask_piecetask_synchronizer.go 46.95% <0.00%> (-9.76%) ⬇️
client/daemon/peer/piece_broker.go 89.74% <0.00%> (-2.57%) ⬇️

Copy link
Member

@KubeStacker KubeStacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KubeStacker KubeStacker merged commit 56c8812 into main Mar 31, 2022
@KubeStacker KubeStacker deleted the feature/manager branch March 31, 2022 02:41
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants