Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scheduler add block peers set #1202

Merged
merged 1 commit into from
Mar 28, 2022
Merged

feat: scheduler add block peers set #1202

merged 1 commit into from
Mar 28, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Scheduler add block peers set.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 28, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 28, 2022 04:02
@gaius-qi gaius-qi self-assigned this Mar 28, 2022
@gaius-qi gaius-qi force-pushed the feature/block-peer branch 2 times, most recently from d6e1dcc to e6bcaf1 Compare March 28, 2022 04:16
@gaius-qi gaius-qi force-pushed the feature/block-peer branch from e6bcaf1 to cb534f1 Compare March 28, 2022 04:23
@codecov-commenter
Copy link

Codecov Report

Merging #1202 (cb534f1) into main (fa3c2c7) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
- Coverage   46.59%   46.45%   -0.15%     
==========================================
  Files         133      133              
  Lines       10528    10523       -5     
==========================================
- Hits         4906     4888      -18     
- Misses       5068     5081      +13     
  Partials      554      554              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.45% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/peer.go 77.71% <100.00%> (+0.13%) ⬆️
scheduler/service/service.go 86.21% <100.00%> (-0.24%) ⬇️
...ent/daemon/peer/peertask_piecetask_synchronizer.go 46.95% <0.00%> (-9.76%) ⬇️
client/config/dfget.go 29.06% <0.00%> (+2.32%) ⬆️
client/daemon/peer/piece_broker.go 92.30% <0.00%> (+2.56%) ⬆️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KubeStacker KubeStacker merged commit b726ad1 into main Mar 28, 2022
@KubeStacker KubeStacker deleted the feature/block-peer branch March 28, 2022 06:32
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants